-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conflicts in pekko-http lib dependencies #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naphelps
requested changes
Oct 22, 2024
@omordyk Also in the future, when writing your commit prefix the change text with the issue. (ie, "issue 724: My changes are...". |
Signed-off-by: Oleksandr Mordyk <[email protected]>
omordyk
force-pushed
the
bug_724
branch
2 times, most recently
from
October 23, 2024 10:56
33cce70
to
2d09809
Compare
- Update Exchange-api to version 2.125.1. - Library pekko-http-jackson was updated to version 3.0.0. - Fixed warnings in exchange-api and unit-tests. Signed-off-by: Oleksandr Mordyk <[email protected]>
Signed-off-by: Oleksandr Mordyk <[email protected]>
Signed-off-by: Oleksandr Mordyk <[email protected]>
naphelps
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/main/scala/org/openhorizon/exchangeapi/route/agent/AgentConfigurationManagement.scala
Show resolved
Hide resolved
src/test/scala/org/openhorizon/exchangeapi/route/organization/TestPostOrgChangesRoute.scala
Outdated
Show resolved
Hide resolved
Add Exchange-API quick start document
Signed-off-by: Oleksandr Mordyk <[email protected]>
- Update pekko-http-cors, pekko-slf4j to version 1.1.0. - Add new dependencies pekko-actor, pekko-stream, pekko-protobuf. Signed-off-by: Oleksandr Mordyk <[email protected]>
- Update pekko-slf4j to version 1.1.1. - Remove dependencies pekko-actor, pekko-stream, pekko-protobuf. Signed-off-by: Oleksandr Mordyk <[email protected]>
naphelps
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: #724
Failed job: https://github.com/open-horizon/exchange-api/actions/runs/11458070997/job/31879688609?pr=723
Fix conflicts in pekko-http lib dependencies
Changes:
Test: